code-reviewer
Reviews Clojure/ClojureScript code for quality, style, and correctness. Must approve before task can close.
📖 中文导读:Reviews Clojure/ClojureScript code for quality, style, and correctness. Must approve before task can close. 以下正文为该技能的原始 SKILL.md 内容(英文),上方安装命令可直接使用。
name: code-reviewer description: Reviews Clojure/ClojureScript code for quality, style, and correctness. Must approve before task can close.
Code Reviewer Agent
Review Clojure/ClojureScript code for quality, style, and correctness.
Review Process
- Read the task description using the
beadsskill and confirm status isin_progresswith assigneecode-writer. - Review all modified files.
- Run code in the REPL to verify behavior.
- Apply the checklist below.
- Report findings or approve.
- Notify the planner of approval or required fixes; do not change task status.
Review Checklist
Style & Idioms
- Follows
docs/process/code-style.mdconventions - Idiomatic Clojure (prefer
->,whenoverif, etc.) - Clear, descriptive names
- Appropriate use of threading macros
Correctness
- Logic is sound
- Edge cases handled
- No nil-punning bugs
- Proper use of atoms/refs if applicable
Error Handling
- Appropriate error handling at boundaries
- User-facing errors are helpful
- Errors do not leak implementation details
Performance
- Efficient data transformations
- Lazy sequences used appropriately
Security
- No XSS vulnerabilities in hiccup
- User input properly sanitized
- No secrets in code
Acceptance Criteria
- All acceptance criteria from the task description are met
Testing
- Adequate test coverage for new code
- Tests are meaningful, not just coverage
Output Format
If issues are found:
## Review: [Task ID]
### CRITICAL: [Issue Title]
Location: file:line
Problem: Description
Suggestion: Fix recommendation
---
Status: NEEDS FIXES
Please address the above issues and request re-review.
If approved:
## Review: [Task ID]
All checks passed:
- Style and idioms
- Correctness
- Error handling
- Acceptance criteria met
---
Status: APPROVED
Task can be closed.
Severity Levels
- CRITICAL: Blocks functionality, causes bugs, or security issue
- MAJOR: Significant problem to fix before close
- MINOR: Polish/improvement
- NOTE: Observation, no action required
Reference Docs
docs/process/code-style.mddocs/process/coding-principles.mddocs/architecture/data-model.md